Polyfill AbortSignal.any in PDF.js legacy builds
#19218
Conversation
With recent changes, in particular PR 19216, we're now relying on `AbortSignal.any` in a way that cannot just be skipped with pre-processor statements as done previously. This is problematical since `AbortSignal.any` is fairly new functionality, see https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal/any_static#browser_compatibility, that's not available in all browsers that we support. Instead it seems that we need to add a polyfill, however I unfortunately wasn't able to find one on NPM. In fact the only one I could find was https://gist.github.com/CNSeniorious000/9fc1a72e45358dd7c9e2f16e5d26df5c, which doesn't contain any licensing information. *Note:* Given the use of pre-processor statements, this polfill will *not* be included in the Firefox PDF Viewer.
Snuffleupagus
force-pushed
the
AbortSignal-any-polyfill
branch
from
e206def to
dcca4d0
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/bc4b3e916b58494/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1e1346ffc48d657/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/1e1346ffc48d657/output.txt Total script time: 28.42 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/bc4b3e916b58494/output.txt Total script time: 52.07 mins
|
|
Note that the only "alternative" to this PR would be to raise the minimum supported browser versions very significantly, see https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal/any_static#browser_compatibility, which I cannot imagine would go over particularly well (since users already somewhat regularly complain about the requirements). |
There was a problem hiding this comment.
The change looks good to me. @calixteman Could you comment on the licensing bit here before we land this?
|
sorry, if there isn't any licenses associated to this code, it can't be merged. |
Just in case it's not clear, please note that the code will not be included in the Firefox PDF Viewer.
As mentioned in #19218 (comment), there doesn't appear to be one.
Sorry, but that's then more work than I'm willing to put into an issue that doesn't affect me. Hence it seems that we need to move forward with the alternative outlined in #19218 (comment), which is bumping the supported browsers significantly (and probably make that an |
Even with that, we can't take the risk. Sorry |
With recent changes, in particular PR #19216, we're now relying on
AbortSignal.anyin a way that cannot just be skipped with pre-processor statements as done previously.This is problematical since
AbortSignal.anyis fairly new functionality, see https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal/any_static#browser_compatibility, that's not available in all browsers that we support.Instead it seems that we need to add a polyfill, however I unfortunately wasn't able to find one on NPM. In fact the only one I could find was https://gist.github.com/CNSeniorious000/9fc1a72e45358dd7c9e2f16e5d26df5c, which doesn't contain any licensing information.
Note: Given the use of pre-processor statements, this polfill will not be included in the Firefox PDF Viewer.